Open micahlisonbee opened 9 years ago
basham
commented
9 years ago Thanks for posting the issue. When I used npm link when developing the module, it all worked as intended. However, I failed to test it as a true npm dependency, and I'm noticing similar module reference problems. Will investigate.
micahlisonbee
commented
9 years ago Cool, thanks for looking in to it.
basham
commented
9 years ago @micahlisonbee Sorry for putting no work into this issue to date. However, it seems as if this project did what it was intending, inspiring this feature to be included officially in BrowserSync. You can follow its progress on the multi-instance branch. Therefore, I don't see much point investing further time in this project, even to fix this critical bug. That is, unless you have a particular need that the multi-instance branch doesn't solve for you.
shakyShane
commented
9 years ago @basham thanks for updating - just one note though, anyone wanting to check out the new functionality should actually use the develop branch as this is much further ahead & is what will ultimately land in master.
https://github.com/shakyShane/browser-sync/tree/develop
:)
basham
commented
9 years ago @shakyShane Excellent. Thanks for the correction. The depreciation notice on the README now correctly links to the develop branch.
When creating a new browser-sync-instance I get:
Error: Cannot find module './node_modules/browser-sync/package.json' at Function.Module._resolveFilename (module.js:338:15) at Function.Module._load (module.js:280:25) at Module.require (module.js:364:17) at require (module.js:380:17) at Object. (/Code/Boncom/boncom-labs-icarus/node_modules/browser-sync-instance/index.js:8:21)
at Module._compile (module.js:456:26)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
at Module.require (module.js:364:17) The issue is resolved by changing the refs to "../../node_modules/browser-sync/..." Not sure if that's a good fix though...