Opinion about different routers

ivan-kleshnin commented 9 years ago

I see you've implemented Cycle-Demo with both Director and Router-5 alternatives. Which one do you like the best?

My opinion is that Router5 is a much better library than Director. The last one does not even allow to build URLs which is a disaster.

Second thing is that Cycle-Director code is a total mess. Cycle-Router5 code looks clean and reasonable.

I also looked for another routing libraries and Router5 is my current TOP-1.

What's your opinion?

ivan-kleshnin commented 9 years ago

I don't like this part

function model(actions) {
  return {
    page$: actions.transition$.map(({toState, fromState}) => {
      // Since Router5 doesn't allow arbitrary data to be forwarded through it,
      // find the original route object and initiate its handler.
      let routeName = toState.name;
      let route = routes.filter(({name}) => name === routeName)[0]; 
      let content = route.handler();
      return {routeName, content};
    }),
  };
}

As soon as routes will be nested it will complicate things as will need to flatten route object before every lookup.

Since Router5 doesn't allow arbitrary data to be forwarded through it, find the original route object and initiate its handler.

Maybe we shouldn't couple routes and handlers at all.

I mean, maybe we need two or more datastructures:

// For router5 consumption
let routes = [
  {path: "/users/", name: "users.index"},
  {path: "/users/:id", name: "users.detail"},
];

// For app consumption
let contentHandlers = {
  "users.index": () => ...,
  "users.detail": () => ...,
};

And then:

function model(actions) {
  return {
    page$: actions.transition$.map(({toState, fromState}) => {
      let content = contentHandlers[toState.name]();
      return {routeName, content}; // possible to extend with other handler besides "content"
    }),
  };
}

What do you think about this?

I also thought about component approach like http://router5.github.io/docs/with-react.html#/inbox but as CycleJS team is going to remove custom elements it's hard to predict how to arrange all this together.