search

bashbers / csharp-algorithms-hacktoberfest2018

Hacktoberfest repository which over time will include loads of c# algorithms.
https://hacktoberfest.digitalocean.com/
3 stars 29 forks source link

The complete project is messed up, no structure in the solution, tests not working. I'm fixing this. #33

Closed dschemp closed 5 years ago

dschemp commented 5 years ago

Gonna publish a cleaned up version of this repo which should compile without problems, has a file structure in the solution, and does not resemble the anarchy as it does currently.

Edit: would appreciate the hacktoberfest label

dschemp commented 5 years ago

tbh, screw that. github isn't letting me make a pr for this. thx4nothing

lucashorward commented 5 years ago

  1. Github won't allow a PR because you're not a contributor. You can, however, make a fork of this repository and make a PR from there to this repository. That's how public repo's on Github work, and as far as I know, have always worked.

  2. Please keep your criticism constructive and decent. Rudeness displayed in this "issue" will not be tolerated.

Have a nice day.

dschemp commented 5 years ago

The thing is that I have done it exactly as you said: fork it and push, but it won't let me PR it.

lucashorward commented 5 years ago

I see. Your filestructure branch is 55 commits (?) behind the master of this repo. Because of this, git does not recognize the two repo's as being the same. Normally, you could force push (as your master branch is equal, I assume you did a reset), however that does not apply to forks.

There are several issues with going back 55 commits, largest of all being that all the algorithms made by the contributors on this repo would be removed, which would be a shame.

I would advise you to not reset back to the first commit like you have done now, but try to fix the project as is, if you would still want to do that.

Upon inspection (I haven't been active here in a few weeks), I agree with you that the file structure is not good, and it has (somehow) changed from my initial setup. So, if you're for whatever reason unable or unwilling to fix it (I can understand), we will take a look anyway.

Thank you for your time.