search

bashclub / proxmox-zfs-postinstall

This script is designed to run on a fresh installed Proxmox server, configures `pve-no-subscription` repository, adjusts `zfs_arc_cache` and installs basic tools like `zfs-auto-snapshot` or `ifupdown2`
https://sysops.tv
117 stars 29 forks source link

Update proxmox-zfs-postinstall.sh #13

Closed MAButz closed 1 year ago

MAButz commented 1 year ago

Hi, this is my suggestion for commit #11

teissler commented 1 year ago

Please change (y/n)? in line 170 of your change to (y/N)?. This way it is easier to understand that everything except "y" doesn't enables the pve-no-subscription repo.

An additional tr '[:upper:]' '[:lower:]' for response would also improve the scripts failure proofness.

MAButz commented 1 year ago

Thanks, changes in https://github.com/bashclub/proxmox-zfs-postinstall/pull/13/commits/b46d8c0a3952e123a3901e19edaecf60aaf187f3