search

bashleigh / typeorm-polymorphic

Typeorm polymorphic relationship management
MIT License
198 stars 38 forks source link

feat: add typeorm support ^0.3.0 #37

Closed rpvsilva closed 1 year ago

rpvsilva commented 1 year ago

Since there is no response from #34 I've pulled the changes from @dominicbachmann and rebased with master, the tests are passing also. Also, I've upgraded the MySQL client version to 2 to test with MySQL v8 and it's working.

jspizziri commented 1 year ago

@bashleigh would love to see typeorm 0.3.0 support added to this lib.

Thanks!

jspizziri commented 1 year ago

@rpvsilva you haven't published your fork have you?

jspizziri commented 1 year ago

After looking more closely at this PR, I've decided to submit a different approach to this upgrade.

Please see https://github.com/bashleigh/typeorm-polymorphic/pull/38 which explains the motivation.

rpvsilva commented 1 year ago

Closing PR because of #38