basho-labs / ansible-riak

Ansible roles for Riak
Other
33 stars 32 forks source link

Unecessary backup of files #56

Closed jsmartin closed 7 years ago

jsmartin commented 8 years ago

https://github.com/basho-labs/ansible-riak/blob/develop/tasks/main.yml#L45 https://github.com/basho-labs/ansible-riak/blob/develop/tasks/main.yml#L50

The template module has a "backup" parameter that will automatically backup and timestamp the file it replaces, should negate the need for these.

http://docs.ansible.com/ansible/template_module.html

christophermancini commented 8 years ago

Is that a new feature with 2.0 or has it been there for a while?

jsmartin commented 8 years ago

It's been around awhile, not sure exactly how long.

christophermancini commented 8 years ago

Updated in #57. If you could give it a glance, I would appreciate it.