search

basho-labs / puppet-riak

A puppet module to deploy Riak clusters
Apache License 2.0
33 stars 37 forks source link

Installing via repositories now. Some minor fixes #1

Closed jsmartin closed 11 years ago

jsmartin commented 11 years ago

Default vagrant box OS is CentOS until Riak 1.2.1 is released due to bug in debian init script.

haf commented 11 years ago

Hey man. What do you think of allowing either the user to download the deb/rpm or using the repos, just like the cookbook for Chef is doing? All we have to do, is to check the value of the parameter like we're doing with the template here for example

jsmartin commented 11 years ago

In my experience, people generally don't install packages from files using dpkg or rpm unless they need to. If we have repos we should make it the default.

haf commented 11 years ago

Absolutely, let's make it the default - I'm thinking that if they do fill out that they want from http, all we have to do it perform a switch-check and they can have it.

jsmartin commented 11 years ago

Sounds good to me. I guess I have to put that stuff back in? Or do you want to accept this pull request and do it?

haf commented 11 years ago

I can fix it if you prefer. I'll have a look at it.

jsmartin commented 11 years ago

Hey I updated my master branch.. I made downloading from url optional by disabled by default. It's kinda messy, but it works.

haf commented 11 years ago

Ok, cool. I'm merging and continuing on my side.