basho-labs / puppet-riak

A puppet module to deploy Riak clusters
Apache License 2.0
33 stars 37 forks source link

`rake vagrant:up` has trouble starting up Riak on CentOS 6.x #25

Closed L2G closed 10 years ago

L2G commented 11 years ago

For some reason I can't get this to start Riak on CentOS, not even from a fresh GitHub clone. I've uploaded the output of rake vagrant:up on my system.

L2G commented 11 years ago
$ git describe --tags
v0.1.1-35-ga79cdc4
haf commented 11 years ago

That I can look into however. Give me a minute I'm compiling anyways.

haf commented 11 years ago

Hint: I'm gonna do vagrant ssh -c 'service riak start' and look at the output.

haf commented 11 years ago

Ok, that gives:

[root@vagrant-centos63 vagrant]# /sbin/service riak start
Starting riak: root is not in the sudoers file.  This incident will be reported.
                                                           [FAILED]

So that points to a regression in the riak packaging, I would guess:

[root@vagrant-centos63 vagrant]# rpm -qi riak
Name        : riak                         Relocations: (not relocatable)
Version     : 1.4.2                             Vendor: Basho Technologies, Inc
Release     : 1.el6                         Build Date: tor 29 aug 2013 17.06.09
Install Date: ons 25 sep 2013 18.26.20         Build Host: build-centos-6-64
Group       : Development/Libraries         Source RPM: riak-1.4.2-1.el6.src.rpm
Size        : 46734755                         License: Apache 2
Signature   : RSA/SHA1, fre 30 aug 2013 10.39.59, Key ID 060dd38bbcffced5
Packager    : Basho Package Maintainer <packaging@basho.com>
URL         : http://basho.com
Summary     : Riak is a distributed data store
Description :
Riak is a distributed data store
root@vagrant-centos63 vagrant]# yum remove riak
# snip
[root@vagrant-centos63 vagrant]# yum install riak-1.3.2-1.el6.x86_64
# snip
[root@vagrant-centos63 vagrant]# service riak start
Starting Riak:                                             [  OK  ]
[root@vagrant-centos63 vagrant]# chown root /etc/riak
[root@vagrant-centos63 vagrant]# chgrp root /etc/riak
[root@vagrant-centos63 vagrant]# service riak start
Riak is already running
[root@vagrant-centos63 vagrant]# service riak stop
Stopping Riak:                                             [  OK  ]
[root@vagrant-centos63 vagrant]# service riak start
Starting Riak:                                             [  OK  ]

Perhaps @jsmartin can help?

haf commented 11 years ago

Suits me right that I got a deadlock in my compilation/CI suite.

L2G commented 11 years ago

I think you are right that the bug is not in the Puppet module after all. It looks like an error of omission in the /etc/init.d/riak script. Is https://github.com/basho/riak the right place to report this?

--- /etc/init.d/riak.orig   2013-08-29 21:06:06.000000000 +0000
+++ /etc/init.d/riak    2013-09-25 23:13:48.322629823 +0000
@@ -63,16 +63,17 @@
         check_pid_status
         RETVAL=$?
         if [ $RETVAL -eq 1 ]; then
             break
         fi
     done
     if [ $RETVAL -eq 1 ]; then
         rm -f $lockfile $pidfile
+        RETVAL=0
         success
     else
         failure $"$NAME stop"
     fi
     echo
     return $RETVAL
 }
haf commented 11 years ago

Yes, probably, or we can just ping people until one of them knows how to fix the bug in riak ;), ping @seancribbs.

jaredmorrow commented 10 years ago

This issue has already been fixed and will be in 2.0 or any future version of Riak 1.4. Sorry for the troubles.

haf commented 10 years ago

@L2G Does it work with latest?

haf commented 10 years ago

Closing.