search

basho-labs / puppet-riak

A puppet module to deploy Riak clusters
Apache License 2.0
33 stars 37 forks source link

Incorrect usage of anchor tags #3

Closed timurb closed 11 years ago

timurb commented 11 years ago

Hi,

I've taken a quick look at your code and have found a supposed to be a bug: https://github.com/haf/puppet-riak/blob/master/manifests/init.pp#L139 https://github.com/haf/puppet-riak/blob/master/manifests/init.pp#L220

The idea of anchors is to have anchor start before EVERY resource of the class and anchor end after EVERY resource of the class. Otherwise they do not make much sense.

So you are likely to need to add require => Anchor[riak::start], before => Anchor[riak::end] to every resource of the class

Cheers!

haf commented 11 years ago

Thanks for spotting it! :)