search

basho-labs / puppet-riak

A puppet module to deploy Riak clusters
Apache License 2.0
33 stars 37 forks source link

Specs broken #35

Closed L2G closed 9 years ago

L2G commented 10 years ago

Am I running the specs incorrectly? Please see the Travis output at the link below. I have also run the specs on my laptop and within a VM on my laptop, and the results are nearly identical.

https://travis-ci.org/L2G/puppet-riak/builds/19171821

haf commented 10 years ago

Yes, the specs are broken. At the point where they were written, the quality of the unit testing tools from puppetlabs was really bad and I ran into a lot of issues just trying to test the code. I would happily merge a new revamped test suite.

L2G commented 10 years ago

I can live with that. I just thought I was overlooking something vital somewhere. :-)

If I can get these working again, I'll follow up.

mbbroberg commented 9 years ago

Hey @L2G or @haf - any improvements here? I'll factor this issue into the community rating for this code. You can see what we're trying to achieve here: https://github.com/basho-labs/the-riak-community/blob/master/config-mgmt-strategy.md

I'd love your help if you still have the need :+1:

danieldreier commented 9 years ago

I re-ran specs on ruby 2.1.5 by doing a bundle install and a bundle exec rake specs. All tests failed, so this is still a valid issue. Not blaming anybody; rspec-puppet with hiera is something I've never managed to get working. I know it's possible, just have't made it work myself.

mbbroberg commented 9 years ago

Moving as Ready then!

danieldreier commented 9 years ago

this will be resolved if https://github.com/basho-labs/puppet-riak/pull/52 is merged because that has passing tests.

danieldreier commented 9 years ago

Closing because https://github.com/basho-labs/puppet-riak/pull/52 was merged. Tests now pass, although until https://github.com/basho-labs/puppet-riak/issues/54 is addressed the link to travis results will be broken.