search

basho-labs / puppet-riak

A puppet module to deploy Riak clusters
Apache License 2.0
33 stars 37 forks source link

Making Package['curl'] compatible if it is already defined somewhere els... #36

Closed desc closed 10 years ago

desc commented 10 years ago

In case that Package['curl'] is already defined somewhere else, this would generate an error.

Error 400 on SERVER: Duplicate declaration: Package[curl] is already declared in file $foo.

To avoid this error, Package['$name'] should only match, if needed.

haf commented 10 years ago

Better then to either use ensure_packages or to require => Package['curl'] in this module. If you define things optionally, you lose the ability to have deterministic catalogue compilations afaik.

desc commented 10 years ago

Thanks.

haf commented 10 years ago

So that said, a PR I would merge would be a removal of the declaration and a change in the README and a version bump.