search

basho-labs / puppet-riak

A puppet module to deploy Riak clusters
Apache License 2.0
33 stars 37 forks source link

Ensures compliances with style guide #4

Closed ghoneycutt closed 11 years ago

jsmartin commented 11 years ago

Thanks for the pull request! I'm at a conference this week but I will test this out as soon as I get a chance, likely Monday.

haf commented 11 years ago

I think it looks nice. It's mostly whitespace fixes.

haf commented 11 years ago

@ghoneycutt merging it. Do you btw know how one does deal with the puppet-hiera module nowadays? Should I include it? (says hiera_hash etc are already defined)?

ghoneycutt commented 11 years ago

You have it listed as a dependency in your Modulefile, which is great. No need to include it, as it is just libraries which are automatically loaded. Basically, you're all good :)

haf commented 11 years ago

@ghoneycutt But when looking at the page at the forge: http://forge.puppetlabs.com/haf/riak - the module doesn't properly list puppet-hiera as a dependency - why is this?

ghoneycutt commented 11 years ago

Check out https://projects.puppetlabs.com/issues/4088

haf commented 11 years ago

Rightyo - I'm going to chill then, because there's not much I can do about that... Thanks for looking into it.