search

basho-labs / puppet-riak

A puppet module to deploy Riak clusters
Apache License 2.0
33 stars 37 forks source link

allow setting the ip to listen on #40

Closed wleese closed 10 years ago

wleese commented 10 years ago

Add new argument 'riak::ip' in order to explicitly set the ip riak services listen on. The previous value of $::ipaddress is rather brittle as it amounts to: ip that's first parsed from ifconfig and doesn't match ^127.

Old behaviour is preserved by using $::ipaddress as default.

I was unable to run the spec tests by following the documentation. End result on every test was:

Error from DataBinding 'hiera' while looking up 'riak::version': FileSystem implementation expected Pathname, got: 'Hash'

Testing in vagrant showed the desired changes with no regressions however.

haf commented 10 years ago

Sorry to hear about your tests not running. I think it might be versions of puppet not playing nice with the testing framework.

Nice PR, thank you! Will merge!