basho-labs / puppet-riak

A puppet module to deploy Riak clusters
Apache License 2.0
33 stars 37 forks source link

Version 0.2.2 (via https://forge.puppetlabs.com/basholabs/riak) is not compatible with Puppet 3.7 #68

Open fadushin opened 9 years ago

fadushin commented 9 years ago

When running version 0.2.2 on Puppet 3.7, I get:

[riak@dev1 ~]$ sudo puppet agent -t Info: Retrieving pluginfacts Info: Retrieving plugin Info: Loading facts Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Syntax error at 'String'; expected ')' at /etc/puppet/modules/riak/manifests/init.pp:11 on node dev1.home Warning: Not using cache on failed catalog Error: Could not retrieve catalog; skipping run

On my puppet master:

[root@marx manifests]# puppet module list Warning: Missing dependency 'puppetlabs-apt': 'basholabs-riak' (v0.2.2) requires 'puppetlabs-apt' (>= 1.0.0 <2.0.0) Warning: Missing dependency 'puppetlabs-stdlib': 'basholabs-riak' (v0.2.2) requires 'puppetlabs-stdlib' (>= 4.0.0 <5.0.0) /etc/puppet/modules ├── base (???) ├── basholabs-riak (v0.2.2) ├── puppetlabs-apt (v1.8.0) ├── puppetlabs-firewall (v1.5.0) ├── puppetlabs-ntp (v3.3.0) └── puppetlabs-stdlib (v4.6.0) /usr/share/puppet/modules (no modules installed)

Cornellio commented 9 years ago

This will sound strange, but try deleting metadata.json in the Riak module.

I have seen this inscrutable error disappear by doing this, although it wouldn't explain the root cause.

-- Pete

On May 8, 2015, at 2:07 PM, Fred Dushin notifications@github.com wrote:

When running version 0.2.2 on Puppet 3.7, I get:

[riak@dev1 ~]$ sudo puppet agent -t Info: Retrieving pluginfacts Info: Retrieving plugin Info: Loading facts Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Syntax error at 'String'; expected ')' at /etc/puppet/modules/riak/manifests/init.pp:11 on node dev1.home Warning: Not using cache on failed catalog Error: Could not retrieve catalog; skipping run

On my puppet master:

[root@marx manifests]# puppet module list Warning: Missing dependency 'puppetlabs-apt': 'basholabs-riak' (v0.2.2) requires 'puppetlabs-apt' (>= 1.0.0 <2.0.0) Warning: Missing dependency 'puppetlabs-stdlib': 'basholabs-riak' (v0.2.2) requires 'puppetlabs-stdlib' (>= 4.0.0 <5.0.0) /etc/puppet/modules ├── base (???) ├── basholabs-riak (v0.2.2) ├── puppetlabs-apt (v1.8.0) ├── puppetlabs-firewall (v1.5.0) ├── puppetlabs-ntp (v3.3.0) └── puppetlabs-stdlib (v4.6.0) /usr/share/puppet/modules (no modules installed)

― Reply to this email directly or view it on GitHub.

ciaby commented 9 years ago

I got the same error on Puppet 3.7.5. Tried deleting the metadata.json file, doesn't change anything... Any other clue? I'm running the latest master from the github repository.

Cornellio commented 9 years ago

No other clues at this point. I will try to reproduce. What OS release and version are you running? Make sure you have the future parser enabled.

Pete

ciaby commented 9 years ago

Ubuntu 14.04 (on the puppet master) and 12.04 (on the agents). Puppet 3.7.5-3.8.1

ciaby commented 9 years ago

Ok, you were right, I fixed by enabling the future parser. One thing that doesn't work is the repository management. On a ubuntu precise, you get this:

deb https://packagecloud.io/basho/riak/debian/ precise main deb-src https://packagecloud.io/basho/riak/debian/ precise main

Which is wrong, because it should be more like:

deb https://packagecloud.io/basho/riak/ubuntu/ precise main deb-src https://packagecloud.io/basho/riak/ubuntu/ precise main

Other than that, good job! :)