basho-labs / puppet-riak

A puppet module to deploy Riak clusters
Apache License 2.0
33 stars 37 forks source link

Added tested Ubuntu versions to metadata.json #71

Open GabrielNicolasAvellaneda opened 8 years ago

GabrielNicolasAvellaneda commented 8 years ago

Signed-off-by: GabrielNicolasAvellaneda avellaneda.gabriel@gmail.com

GabrielNicolasAvellaneda commented 8 years ago

@danieldreier Added the two Ubuntu versions that I've tested.

danieldreier commented 8 years ago

It looks like the previous PR probably shouldn't have been merged; for some reason it wasn't caught in the testing:

(quoted from the failed travis build):

  1) riak supported operating systems on ubuntu-12.04-x86_64 riak class without any parameters should contain Class[riak::repository::debian]
     Failure/Error: it { is_expected.to contain_class('riak::repository::debian') }
       expected that the catalogue would contain Class[riak::repository::debian]
     # ./spec/classes/riak_spec.rb:33:in `block (6 levels) in <top (required)>'
  2) riak supported operating systems on ubuntu-14.04-x86_64 riak class without any parameters should contain Class[riak::repository::debian]
     Failure/Error: it { is_expected.to contain_class('riak::repository::debian') }
       expected that the catalogue would contain Class[riak::repository::debian]
     # ./spec/classes/riak_spec.rb:33:in `block (6 levels) in <top (required)>'

The issue is that we have a hardcoded test for riak::repository::debian, which obviously doesn't get included on Ubuntu. Would you mind updating that test? I can help if you run into trouble with it.

GabrielNicolasAvellaneda commented 8 years ago

@danieldreier Sure, I can fix that.

GabrielNicolasAvellaneda commented 8 years ago

@danieldreier Don't know what I'm missing. I will try to run the tests locally first.