Tests failing on initial fork

[dalesit]

I've been following the instructions on CONTRIBUTING.md, and I have run into an issue in that the initial tests have failed before I have done anything.

bundle exec rake lint

succeeds, but

bundle exec rake syntax

throws errors:

---> syntax:manifests
Could not parse for environment *root*: Syntax error at 'String'; expected ')' at /etc/puppetlabs/code/environments/production/modules/puppet-riak/manifests/init.pp:6
Could not parse for environment *root*: Syntax error at 'String'; expected ')' at /etc/puppetlabs/code/environments/production/modules/puppet-riak/manifests/tuning.pp:8
rake aborted!

I'm running puppet 4.2.2.

Not sure what I'm doing wrong - this is all from a clean VM.

Cheers,

Joel

[dalesit]

Looking into this a bit further, the syntax validation fails if using the bundled puppet:

#> puppet parser validate *.pp
Error: Could not parse for environment production: Syntax error at 'String'; expected ')' at /etc/puppetlabs/code/environments/production/modules/puppet-riak/manifests/init.pp:6

#> which puppet
/usr/local/rvm/gems/ruby-2.1.5@puppet-riak/bin/puppet
#> puppet --version
3.7.5

But if I use my system puppet, it validates:

#> /opt/puppetlabs/bin/puppet parser validate *.pp
#>
#> /opt/puppetlabs/bin/puppet --version
4.2.2

Has something moved on requiring a later version of puppet?

[dalesit]

Updating the required puppet version to 4.0.0 in the Gemfile allows the syntax validation to pass.

[jaimeviloria]

specifically syntax check for 'Typing' variables fails on puppet-3.7 with ruby-2.0.0.