basho-labs / puppet-riak

A puppet module to deploy Riak clusters
Apache License 2.0
33 stars 37 forks source link

Make management of the sudo package optional #73

Closed al4 closed 3 years ago

al4 commented 8 years ago

Some environments such as ours use the sudo-ldap package to allow sudo auth against company ldap servers. The riak module currently breaks this by installing the "sudo" package, which in Debian land (and presumably Ubuntu as well) conflicts with and removes the sudo-ldap package.

This pull request adds a "manage_sudo" parameter, set to true by default, which allows us to prevent puppet-riak from installing sudo.

I realise this is somewhat of an edge case and you may want to avoid cluttering the interface to init.pp, so if you have a better place for it I'm happy to refactor it, but looking at the existing layout it seemed most logical to put it beside manage_package and manage_repo.

Or if you feel this is too niche to clutter up the interface fair enough, I'm happy to maintain a patch just figured it would be easiest if it was included upstream.

Thanks for providing this module!