basho-labs / riak-c-client

Riak C Client
Apache License 2.0
20 stars 8 forks source link

Add stringl functions to binary #38

Closed bachpedersen closed 10 years ago

bachpedersen commented 10 years ago

Just a couple of convenience functions for non zero terminated string -> riak_binary

bachpedersen commented 10 years ago

I prefer the short version, gdb will find the location pretty fast, not my call though let me know if I should change it back.

hazen commented 10 years ago

I think I'll take the ideas you have in this PR and incorporate the APIs into another one I'm working on to cleanup riak_binary. When it's done, I'll try to link to this issue.

hazen commented 10 years ago

Hopefully https://github.com/basho/riak-c-client/pull/41 has addressed the fundamentals of what you wanted to get out of this PR. Please comment or create a new one if I'm wrong.