Clean Up Build - Githubissues

basho-labs / riak-c-client

Riak C Client

Apache License 2.0

20 stars 8 forks source link

Clean Up Build #42

Closed hazen closed 10 years ago

hazen commented 10 years ago

Removed the Scons files
Updated build instructions for multiple platforms
Build PBC .h and .c files from riak_pb instead of static versions
Updated build version to 1.0
Addresses https://github.com/basho/riak-c-client/issues/34, https://github.com/basho/riak-c-client/issues/35 and https://github.com/basho/riak-c-client/issues/36

bookshelfdave commented 10 years ago

does this PR bring RCC to v1.0? I see it stamped in Makefile.am. If so, we'll need to tag/release etc.

hazen commented 10 years ago

Upped version to 1.0. Agree we should tag when it's "done."

bookshelfdave commented 10 years ago

This builds fine if I follow the readme :-)

I think we need to: a) give the user a better error message if they haven't cloned riak_pb into this src tree b) add a script + metadata file including riak_pb vsn# to automate the download (similar to rebar deps/locked deps)

bookshelfdave commented 10 years ago

I'd ask clients@basho about the version number. We probably want to avoid 1.0 in the configs until this is actually released.

bookshelfdave commented 10 years ago

@javajolt I pushed some readme updates directly to your branch. Can you give them a quick review?

bookshelfdave commented 10 years ago

:+1:

hazen commented 10 years ago

@metadave I don't see any changes to the README file on the bugfix/bch/cleanup-build branch. Did you push?

bookshelfdave commented 10 years ago

derp, pushed.