Closed bookshelfdave closed 10 years ago
So I tried installing this branch in /tmp/riakc
just for fun and found that we are missing the include path for riak-c-client
itself:
gcc `pkg-config --cflags --libs riak-c-client-sync` taste_of_riak.c -o taste_of_riak
taste_of_riak.c:21:10: fatal error: 'riak.h' file not found
#include <riak.h>
^
1 error generated.
make: *** [all] Error 1
It looks like the -I
includes are not being returned. I think the last line needs to be
Cflags: -I${includedir}
Also, how about simply riak-c-client.pc
and riak-c-client-async.pc
? The default is synchronous, right?
Looks like we also need this:
Libs: -L${libdir} -lriak_c_client-0.5
@javajolt updated based on your feedback.
$ pkg-config --list-all | grep riak
riak-c-client Riak C Client, synchronous implementation - A C client for the Riak Distributed Database
riak-c-client-async Riak C Client, async implementation - A C client for the Riak Distributed Database
Note: I'll need to update the Makefile
in taste-of-riak/C
Didn't we want to leave this open? I can't remember why.
Otherwise, it looks good :+1:
@javajolt I was going to leave it open while I got the Taste of Riak working. I'm thinking of implementing another simple async version to go alongside the sync one, so there might be more changes coming in the next few days.
Tested using a basic build: