Add Integration Tests for Server Error

basho-labs / riak-c-client

Riak C Client

Apache License 2.0

20 stars 8 forks source link

Add Integration Tests for Server Error #70

Closed hazen closed 10 years ago

hazen commented 10 years ago

Clean up uncovered leaks in an error scenario
Rename riak_error message to riak_server_error to avoid confusion
Change how riak_c_cunit either runs only integration tests or unit tests

Note: This PR exercises error conditions so you will see these errors in the stderr output:

2014-03-23 00:50:29 EDT ERRO [27] ERR #0 - Invalid equality query undefined
2014-03-23 00:50:29 EDT CRIT [27] CALLBACK ERROR: Invalid equality query undefined

bookshelfdave commented 10 years ago

Run Summary:    Type  Total    Ran Passed Failed Inactive
              suites      7      1    n/a      0        6
               tests    115     17     17      0        0
             asserts     91     91     91      0      n/a

Elapsed time =    0.166 seconds

what are the 6 inactive tests?

+1 otherwise

hazen commented 10 years ago

Dave - In this PR I changed how the integration test flag works:

Without a command-line argument only the 6 unit test suites will run
With a command-line argument only the 1 integration test suite will run

I did this so I can more easily do Valgrind on only the integration tests. I have a task to go back and cleanup memory on the unit tests, which I'd do once the integration tests are all written.

bookshelfdave commented 10 years ago

right, I'm chalking it up to Sunday AM grogginess