basho-labs / riak-mesos-tools

CLI and other tools for interacting with the Riak Mesos Framework.
Apache License 2.0
3 stars 6 forks source link

Add optional field .riak.node.network_interface_name #29

Closed sanmiguel closed 8 years ago

sanmiguel commented 8 years ago

This PR corresponds to basho-labs/riak-mesos-executor#26

Optionally allow the operator to set .riak.node.network_interface_name and pass it to the scheduler as env var RIAK_MESOS_NODE_IFACE.

Also fix a little bug-ette in RiakMesosConfig.get_any(...) where it would return the parent object if the child specified did not exist.

drewkerrigan commented 8 years ago

Please split riak_mesos/config.py line 89 into 2 lines so that each line is under 79 characters re: https://travis-ci.org/basho-labs/riak-mesos-tools/jobs/147838077#L354

Otherwise 👍 LGTM