basho-labs / riakcs-java-client

Java client for RiakCS and Amazon S3
Apache License 2.0
13 stars 14 forks source link

Javadoc updates, added interfaces to allow easier mocking and gradle support #7

Closed StephenDillon closed 9 years ago

StephenDillon commented 9 years ago

Hey,

I did some updates around the javadoc, source generation, added interfaces and added gradle build file if you guys are interested. I forked it off the cloudfoundry incubator fork but I can re-apply them to a newer branch here if you guys are interested.

Stephen

mbbroberg commented 9 years ago

Great stuff @StephenDillon! As you can see, we haven't updated this repo - it began as a project to learn the S3 protocol internally. Officially speaking, we do no development on this library and we recommend the use of the Amazon S3 client.

Given your work, I'll take some time to migrate this under Basho Labs where we focus on community-maintained code out of support of the company.

Do you have interest in being the maintainer going forward? Either way, thank you for what you've done here!

StephenDillon commented 9 years ago

Sure that would awesome. If you want to port over what you have at the moment I can reapply my changes afterwards.

Thanks! On Mar 31, 2015 8:10 AM, "Matt Brender" notifications@github.com wrote:

Great stuff @StephenDillon https://github.com/StephenDillon! As you can see, we haven't updated this repo - it began as a project to learn the S3 protocol internally. Officially speaking, we do no development on this library and we recommend the use of the Amazon S3 client.

Given your work, I'll take some time to migrate this under Basho Labs https://github.com/basho-labs where we focus on community-maintained code out of support of the company.

Do you have interest in being the maintainer going forward? Either way, thank you for what you've done here!

— Reply to this email directly or view it on GitHub https://github.com/basho/riakcs-java-client/pull/7#issuecomment-88063264 .

mbbroberg commented 9 years ago

I just migrated it @StephenDillon, which thankfully keeps your PR open. You've also been added to @basho-labs/riakcs-java-client-committers and have write access to this repo. Feel free to merge these edits if you find them passing your tests.

And welcome! We're happy to have you as a committer. Let me know if I can do anything to help via email or twitter.

StephenDillon commented 9 years ago

Excellent, I will take a look at resolving the conflicts later.

StephenDillon commented 9 years ago

Hey Matt, can you check the group permissions for me, don't see to be able to push. http://imgur.com/fSzrssN

Thanks!

mbbroberg commented 9 years ago

You bet @StephenDillon - checking!

mbbroberg commented 9 years ago

Good call @StephenDillon - should be good now but lmk!

mbbroberg commented 9 years ago

Hey @StephenDillon - you're more than welcome to merge this when you're ready to do so. Let me know if you need help testing.

StephenDillon commented 9 years ago

I have a branch locally were I am updating it, should be able to push it soon

mbbroberg commented 9 years ago

Hey @StephenDillon - just noticed this hasn't merged yet. Would you care to do so still?

Thanks! :+1:

StephenDillon commented 9 years ago

Hey Matt,

I created a new pull against the latest code. It has a lot of the interface updates some I need to do some investigation to finish, included the fix mentioned around local and updated to use gradle to build. (Added build instructions to readme) It will also generate a javadoc and sources jar https://github.com/basho-labs/riakcs-java-client/pull/9

mbbroberg commented 9 years ago

@StephenDillon you're welcome to merge whichever PR. I follow your lead, sir - you're the maintainer :smile: