basho / basho_bench

A load-generation and testing tool for basically whatever you can write a returning Erlang function for.
Apache License 2.0
311 stars 197 forks source link

fix: broken csv writer #194

Closed fogfish closed 8 years ago

fogfish commented 8 years ago

The summary split feature break cvs writer https://github.com/basho/basho_bench/commit/c1702ebdea5f8acd967290cbcbd774c414f87820

the following snippet is wrong

Module:process_summary({State#state.stats_writer,
                                               State#state.stats_writer_data},
                                              Elapsed, Window, Oks, Errors)

you have to supply State#state.stats_writer_data into worker module

slfritchie commented 8 years ago

Oops, that was an embarrassing bug to let through, thanks for the PR!

slfritchie commented 8 years ago

I added a minor amount of cleanup in commit dfdafc8d8e30e50f63a21927358930e22cf9675c.