search

basho / bitcask

because you need another a key/value storage engine
1.29k stars 173 forks source link

Avoid fold crash on invalid key [JIRA: RIAK-2090] #214

Closed engelsanchez closed 9 years ago

engelsanchez commented 9 years ago

If the user defined key transformation function fails on a key read from disk, do not crash the process. Instead, keep going and log an error.

This is the second part of the fix for https://github.com/basho/bitcask/issues/212

engelsanchez commented 9 years ago

@mrallen1 Hopefully all your style comments were addressed in the commit d0ba42a. Let me know if it looks better or worse!

jadeallenx commented 9 years ago

:+1: d0ba42a

jadeallenx commented 9 years ago

Tests pass. Dialyzer clean. Looks good.

engelsanchez commented 9 years ago

@borshop merge

Basho-JIRA commented 9 years ago

Per comments on https://github.com/basho/bitcask/issues/212 this is fixed in Bitcask 1.7.2 - just need to ensure we pick up 1.7.2 for Riak 2.1.2, which we should be (confirmed that rebar.config.lock has correct SHA).

_[posted via JIRA by Douglas Rohrer]_

Basho-JIRA commented 9 years ago

Checked both riak and riak_ee 2.1 rebar.config.lock files and correct version of Bitcask is specified so we should pick this up.

_[posted via JIRA by Douglas Rohrer]_