search

basho / bitcask

because you need another a key/value storage engine
1.29k stars 173 forks source link

Erlang 18.0 now() fix. #221

Closed billstclair closed 2 years ago

billstclair commented 9 years ago

Make bitcask work in OTP 18.0.

The rebar.config change temporarily depends on {branch, "develop"} of cuttlefish. When it's merged, it should really depend on a new tag on cuttlefish. I need the OTP 18 changes there that are newer than any current tag.

This fixes the OTP 18 deprecation warnings for erlang:now(), which are fatal due to warnings_as_errors in the erl_opts setting in rebar.config.

The bitcask_timestamp.erl code is from http://www.erlang.org/doc/apps/erts/time_compat.erl

The modified bitcask application passes "make test" in basho/otp branches basho-otp-16, basho-otp-17, and basho-otp-18. "All 81 tests passed."

slfritchie commented 8 years ago

Hi, Bill, sorry about the delay, we at Basho have been bad recently about handling outside PRs for some of our repos.

This PR will take a lot of time to review, for the same reasons that a similar riak_core PR is delayed. Please see the discussion at https://github.com/basho/riak_core/pull/785#issuecomment-145449131 and following.

martincox commented 2 years ago

No longer relevant as bitcask supports later OTP versions.