search

basho / bitcask

because you need another a key/value storage engine
1.28k stars 171 forks source link

OTP21 support #259

Open Vagabond opened 6 years ago

Vagabond commented 6 years ago

This branch makes bitcask work (although there might be a slight performance degredation) on OTP21 and it fixes all the dialyzer warnings.

Vagabond commented 6 years ago

I do, do you remember how to run it (or I can allocate you one for a while)?

evanmcc commented 6 years ago

make pulse should work as a place to start, iirc.

Vagabond commented 6 years ago

I broke pulse support pretty bad, I need to rework it.

hrobeers commented 5 years ago

This works for me with Erlang/OTP 21 [erts-10.0.8] and Elixir 1.7.3

Using the dep below in my Elixir Mix file: {:bitcask, git: "https://github.com/helium/bitcask.git", branch: "modernize"}

Thanks!

ypaq commented 5 years ago

Looks like the helium fork is gone. Any chance this could be merged anyhow?

evanmcc commented 5 years ago

I think it got archived, but still should be pullable?

my impression was that this worked fine, but getting all the make targets working was still a WIP. I can push those changes to my personal branch when I get them working if maintainers want to merge this without them.

On Mon, Jun 17, 2019, 2:12 PM ypaq notifications@github.com wrote:

Looks like the helium fork is gone. Any chance this could be merged anyhow?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/basho/bitcask/pull/259?email_source=notifications&email_token=AAAJQLELFNCH4CR3T3WECRLP2744TA5CNFSM4FJVN52KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX4O2XQ#issuecomment-502852958, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAJQLEUMQSA7LZSHXUZ2BDP2744TANCNFSM4FJVN52A .

hrobeers commented 5 years ago

This is a clone of the helium modernize branch: https://github.com/hrobeers/bitcask