search

basho / bitcask

because you need another a key/value storage engine
1.28k stars 171 forks source link

Build broken with OTP 21: use of the deprecated get_stacktrace/0 in dependency meck #260

Open yati-sagade opened 5 years ago

yati-sagade commented 5 years ago

get_stacktrace/0 has been removed since OTP 21. The upstream meck project (https://github.com/eproxus/meck) has addressed this, can you please update your fork if possible?

This is the error I see when I try to build:

$ make
...
==> meck (compile)
Compiled src/meck_history.erl
Compiled src/meck_proc.erl
/home/ysagade/bitcask/deps/meck/src/meck_code_gen.erl:182: erlang:get_stacktrace/0: deprecated; use the new try/catch syntax for retrieving the stack backtrace
ERROR: compile failed while processing /home/ysagade/bitcask/deps/meck: rebar_abort
make: *** [Makefile:16: compile] Error 1

Do I need to downgrade? Or can m

yati-sagade commented 5 years ago

I guess that alone isn't enough. Are there plans to migrate to R21?

martincox commented 5 years ago

Work has already been done for OTP21, @Vagabond created https://github.com/basho/bitcask/pull/259. Sounds like there are some issues still to be worked out though. As far as I know, no one is looking into them right now, though.

evanmcc commented 5 years ago

I checked out #259 and ran the eqc tests (I've changed jobs since my original comment) and will do some more on an overnight run. Tomorrow, I'll see if I can get the pulse test running. given the limited scope of the PR, I wouldn't expect too much trouble, though. I'm not sure what the current org would want as verification before merging, though.