search

basho / bitcask

because you need another a key/value storage engine
1.28k stars 171 forks source link

Update PULSE tests #264

Closed ThomasArts closed 4 years ago

ThomasArts commented 4 years ago

Clearly the PULSE tests had not been run for a while. PULSE has improved a bit since these tests were written and a lot of instrumentation is no longer needed; we could clean the prodcution code from additions made specifically for PULSE.

There is one change made to the production code: In bitcask_file.erl L152 an error was logged when a file open failed. But the logic in therest of bitcask is that this may happen and that bitcask will retry to open that file. As such it is not an error, but rather a warning. Since the PULSE tests do check the log for errors and this popped up often in those tests, the solution to make it a warning seems helpful.

martinsumner commented 4 years ago

@martincox FYI - this gets the pulse tests working again on bitcask