basho / clique

CLI Framework for Erlang
Apache License 2.0
147 stars 49 forks source link

Friendlier set/show/describe #33

Closed macintux closed 9 years ago

macintux commented 9 years ago

Current:

$ ./riak-admin set
Config Operations require one or more arguments
$ ./riak-admin set foo
Not a Key/Value argument of format: "foo"=<Value>:

$ ./riak-admin set foo=bar
Conf file attempted to set unknown variable: foo

Suggested:

$ ./riak-admin set
Usage: riak-admin set <variable>=<value> [-n <node>|--all]
$ ./riak-admin set foo
Usage: riak-admin set <variable>=<value> [-n <node>|--all]
$ ./riak-admin set foo=bar
Unknown configuration variable: foo
macintux commented 9 years ago

Also strongly suggest doing a 'show' after a set.

Current:

$ ./riak-admin set handoff.outbound=off
$

Preferred:

$ ./riak-admin set handoff.outbound=off
+--------------+----------------+
|     node     |handoff.outbound|
+--------------+----------------+
|dev1@127.0.0.1|      off       |
+--------------+----------------+
andrewjstone commented 9 years ago

Punted on show after set for release. Other suggestions added.