search

basho / clique

CLI Framework for Erlang
Apache License 2.0
147 stars 49 forks source link

Do needed changes to publish on hex #71

Closed Licenser closed 1 month ago

Licenser commented 8 years ago

Hi I've published clique as a hex package, this are the changes necessary to make it hex-able with riak3. Since it is your project it would be great if you'd take over the package, for that you can ask hex.pm to change ownership, until then I'll try to keep it up to date with the latest tagged release.

For the meantime I added myself as a secondary maintainer so that people having questions regarding the package don't bother you, please remove that if you take over the package since I don't want to claim your work as mine.

hazen commented 8 years ago

@Licenser Looks like we have a merge conflict. Did you start with the latest develop?

Licenser commented 8 years ago

No I started with the latest tag since I didn't wanted to publish the package from develop, but I can re-base if you like

Licenser commented 8 years ago

apparently I can't since I suck at gifting -.-

Licenser commented 8 years ago

Took me long enough, got it sorted.

nickelization commented 8 years ago

Hey @Licenser, sorry this has been sitting ignored, I didn't notice until now that you'd added more commits in August. I definitely appreciate the effort to get this included in hex, and it looks like we're actually using an existing version of cuttlefish now, so this mostly looks good.

However, the way you're specifying the cuttlefish dep in rebar.config is not familiar to me. Is the ~> symbol a feature of rebar3, maybe? With rebar2 on my system, if I clone this branch and run "make" I get an error stating "Dependency not available: cuttlefish-~>2.0.8 (undefined)".

Unfortunately Riak is still stuck on rebar2 for now, so we do need to maintain compatibility with that in clique 😞

tsloughter commented 8 years ago

That dep {cuttlefish, "~> 2.0.8"} is a hex dependency. You are right, it will not work with rebar2.