search

basho / clique

CLI Framework for Erlang
Apache License 2.0
147 stars 49 forks source link

Fix failing test on some environments #81

Closed russelldb closed 6 years ago

russelldb commented 6 years ago

On ubuntu 16.04 r16b02_basho10 clique_config test fails when trying to create ets tables (they already exist!) The teardown should have removed them. Rather than a full rabbit hole excavation, I've added a "belt-and-braces" run teardown before setup. This seems to work. I left a comment in place about why the change, and hopefully one day we can fix it properly.

nickelization commented 6 years ago

+1 0e0cfb7

Pretty sure I wrote these tests, and I'm positive they worked at some point...not sure what changed, but that seems like a totally reasonable fix for that failure.

nickelization commented 6 years ago

Oh you know, I think I'm remembering now that sometimes eunit test order changes depending on what platform you're on. Just a hunch, since I don't have time to try it out now, but I bet it might these tests might still work fine on OS X where they were developed, and perhaps running it on Ubuntu changes the order the tests are run in a way that breaks it.

nickelization commented 6 years ago

I'd consider merging this myself but I don't have write access on the repo anymore. Anyone out there that does now or do we have to get in touch with bet365 to restore access?

martincox commented 6 years ago

Doesn't seem to fail for me. So maybe it is temperamental depending on platform. +1

@nickelization I don't think that perms were explicitly removed from anyone as such, but I guess if you want to carry on contributing and getting maintainer access back, that should be possible.

nickelization commented 6 years ago

Ah right so I forgot about this, but I actually left Basho for another job a week or two before they laid everyone off, and at the time they were still following normal procedures for departing employees. So I actually had my membership to the basho orgs explicitly removed. Any idea who I might ask about restoring that? I don't expect to be doing a ton of work, but would be nice to be able to make the occasional contribution.

russelldb commented 6 years ago

@nickelization that @martincox can give you a commit bit. It would be great to have you contributing!

martincox commented 6 years ago

@nickelization I also forgot about this, sorry about that. The more the merrier definitely. I'll add you back shortly. 😄