basho / cuttlefish

never lose your childlike sense of wonder baby cuttlefish, promise me?
Apache License 2.0
205 stars 124 forks source link

Remove +Q and +e flags from being generated if using R15 #114

Closed jaredmorrow closed 10 years ago

jaredmorrow commented 10 years ago

Erlang R15 does not support the +Q or +e flags. This change simple applies a translation to remove those flags if R15 is being used.

seancribbs commented 10 years ago

As @joedevivo pointed out to me privately, this fixes the issue but breaks the unit tests for the schema.

joedevivo commented 10 years ago

@seancribbs and I worked out a solution today that will be able to tell the difference between R15 and R16 versions of these options (shoutout to Bjorn). Watch this PR tomorrow.

jaredmorrow commented 10 years ago

Passed tests on R15B01, R16B02, and R16B02-basho4

+1

jaredmorrow commented 10 years ago

Changing the comparison to fact check the claim that equals to be true led to an eunit failure:

in function cuttlefish:'-otp_test/0-fun-10-'/0 (src/cuttlefish.erl, line 139)
in call from cuttlefish:otp_test/0 (src/cuttlefish.erl, line 139)
**error:{assertion_failed,[{module,cuttlefish},
                   {line,139},
                   {expression,"otp ( \"R16A\" , \"R16A\" )"},
                   {expected,true},
                   {value,false}]}
joedevivo commented 10 years ago

I see where to problem is. I'll take care of it when I get back to the computer

joedevivo commented 10 years ago

OMG it's so much less complicated now.

seancribbs commented 10 years ago

+1 passes on R15B01, R16B01, R16B02-basho3

joedevivo commented 10 years ago

LMAO they changed the naming convention and R17 will just be "17.0"

jaredmorrow commented 10 years ago

Well we have at least another major before having to worry about it. So for now just file an issue.

On Saturday, February 1, 2014, Joe DeVivo notifications@github.com wrote:

LMAO they changed the naming convention and R17 will just be "17.0"

Reply to this email directly or view it on GitHubhttps://github.com/basho/cuttlefish/pull/114#issuecomment-33870111 .