search

basho / cuttlefish

never lose your childlike sense of wonder baby cuttlefish, promise me?
Apache License 2.0
205 stars 124 forks source link

Fiz dialyzer warnings and enable the untyped records warning #123

Closed Vagabond closed 10 years ago

Vagabond commented 10 years ago

This does not address the warnings generated by the ?assert macros used in cuttlefish_unit. I don't really know how to deal with those.

cc @joedevivo @seancribbs

Vagabond commented 10 years ago

I fixed the error type spec as well as the unmatched return values. Some of the unmatched return values I ignore, some I matched, but I may have made the wrong call on some of them, hard to tell.

seancribbs commented 10 years ago

Updating neotoma to 1.7.2 and rebuilding the pegs removed those warnings. The cuttlefish_unit warnings can be addressed by some restructuring, I'll look again in the morning.

seancribbs commented 10 years ago

Eh, I can't leave a dialyzer warning unturned. Pooshed.

joedevivo commented 10 years ago

pulled new neotoma dep, still see this:

conf_parse.erl:99: Expression produces a value of type tid(), but this value is unmatched
cuttlefish_duration_parse.erl:46: Expression produces a value of type tid(), but this value is unmatched
seancribbs commented 10 years ago

@joedevivo Run a clean or remove the .erl files for those, then recompile/dialyze.

joedevivo commented 10 years ago

@seancribbs you're the man!

:+1:

joedevivo commented 10 years ago

BTW, I'm loving the "Fiz" typo

joedevivo commented 10 years ago

@Vagabond merge at will