search

basho / cuttlefish

never lose your childlike sense of wonder baby cuttlefish, promise me?
Apache License 2.0
205 stars 124 forks source link

Test `riak config` commands with legacy app.config / vm.args #142

Closed joedevivo closed 10 years ago

joedevivo commented 10 years ago

https://twitter.com/densoneold/status/691891562

make sure that the command line output for these commands exits cleanly

jaredmorrow commented 10 years ago

So playing around today, I don't think riak config effective works at all with legacy app.config files or advanced.config files. I don't know if it is supposed to work with them or not, but there are variables in the advanced.config of riak_ee that do not show up in the effective list whatsoever.

joedevivo commented 10 years ago

That's ok, it should output the advanced config at the bottom as a comment. with legacy app.config, you can't use this.

jaredmorrow commented 10 years ago

Gotcha, thanks.

joedevivo commented 10 years ago

./bin/riak config effective will actually show output that is misleading when run in legacy config environments.

seancribbs commented 10 years ago

Ayo, you've got a dialyzer warning:

cuttlefish_escript.erl:107: Expression produces a value of type 'ok' | ['ok'], but this value is unmatched
seancribbs commented 10 years ago

:+1: 4cedced

seancribbs commented 10 years ago

@borshop: retry 4cedced

joedevivo commented 10 years ago

@borshop I'm sorry for whatever I did

seancribbs commented 10 years ago

+1 4cedced1

reiddraper commented 10 years ago

I'm not sure why bors isn't commenting. I'm looking into it though.

Vagabond commented 10 years ago

+1 4cedced1

joedevivo commented 10 years ago

@borshop merge