search

basho / cuttlefish

never lose your childlike sense of wonder baby cuttlefish, promise me?
Apache License 2.0
205 stars 124 forks source link

Doesn't compile in R15 because of float_to_list #151

Open glickbot opened 10 years ago

glickbot commented 10 years ago

Won't compile in R15 since float_to_list was introduced in:

https://github.com/basho/cuttlefish/commit/20040a345ec856879b1ca885be07e9d26f364740

Seems to compile in R15 before then.

Mayhap there's a graceful way of handling this, mayhap R15 should be removed from the rebar.conf OTP version check.

I'd like for it to compile in R15 so I can use the erts in Riak to configure 1.4.x app.config files instead of json -> app.config in puppet, etc... but I could also package cuttlefish with node_package and R16 separately.

joedevivo commented 10 years ago

This was introduced for the float and percent data types. I'll take a look next week

joedevivo commented 10 years ago

@glickbot just build the version from the commit before that: https://github.com/basho/cuttlefish/commit/6097f46e712aa6d66511a1bd874dd7ce2c162011 and it should work fine on R15. We'll make this compatible after 2.0