Rework error handling to turn errors into smarter nested tuples

basho / cuttlefish

never lose your childlike sense of wonder baby cuttlefish, promise me?

Apache License 2.0

205 stars 124 forks source link

Closed macintux closed 9 years ago

macintux commented 9 years ago

{error, "Arbitrary string"} becomes {error, {atom(), term()}}
{error, [error()]} becomes {errorlist, [error()]}
Add cuttlefish_error:xlate/1 to take new error tuples and convert to (roughly) same strings as before
Simplify cuttlefish_bytesize:parse/1
General -spec cleanup
API change
Remove cuttlefish_error:format, used nowhere

seancribbs commented 9 years ago

Clearly, my next question is: have you updated all the tests that rely on the previous behavior?

Edit: By "the tests" I mean the schema tests in all the Riak components that define them?

macintux commented 9 years ago

Yes. All tests that expect error tuples have been reviewed and modified, and all tests pass.

seancribbs commented 9 years ago

Just the clique PR? Surely this changes things in kv, core...

macintux commented 9 years ago

Ah-hah. No, I've verified Riak functionality, but didn't look into schema tests. Thanks, will do.

macintux commented 9 years ago

@seancribbs https://github.com/basho/riak_kv/pull/1071 does the needful. No other schema test checks error conditions.

seancribbs commented 9 years ago

:+1: 9fe492d

seancribbs commented 9 years ago

@borshop merge