search

basho / cuttlefish

never lose your childlike sense of wonder baby cuttlefish, promise me?
Apache License 2.0
205 stars 124 forks source link

Able to build cuttlefish w/Erlang 18 #192

Closed yosukehara closed 8 years ago

yosukehara commented 9 years ago

I've modified rebar.config to be able to build this library with Erlang 18.0. I've run make test, the result of which is almost OK but the test did not pass one test w/Erlang 18.0 and 17.5 as below:

module 'conf_parse'
  conf_parse: file_test...[0.007 s] ok
  conf_parse: utf8_test...*failed*
in function erlang:list_to_binary/1
  called as list_to_binary([115,101,116,116,105,110,103,32,61,32,116,104,105,110|...])
in call from conf_parse:parse/1 (src/conf_parse.erl, line 106)
in call from conf_parse:utf8_test/0 (src/conf_parse.erl, line 95)
**error:badarg
  output:<<"">>
module 'conf_parse'
  conf_parse: file_test...[0.008 s] ok
  conf_parse: utf8_test...*failed*
in function erlang:list_to_binary/1
  called as list_to_binary([115,101,116,116,105,110,103,32,61,32,116,104,105,110|...])
in call from conf_parse:parse/1 (src/conf_parse.erl, line 106)
in call from conf_parse:utf8_test/0 (src/conf_parse.erl, line 95)
**error:badarg

It would be nice if you check this request.

macintux commented 9 years ago

Thank you for this submission. We'll definitely take a closer look.

macintux commented 8 years ago

The problem is finally being tackled in #197. Closing this PR.