search

basho / cuttlefish

never lose your childlike sense of wonder baby cuttlefish, promise me?
Apache License 2.0
205 stars 124 forks source link

Cannot compile with Erlang version 18 [JIRA: RIAK-2055] #196

Closed zack-bitcoin closed 8 years ago

zack-bitcoin commented 8 years ago

Can I help you upgrade to support 18? Does it involve a lot of work?

macintux commented 8 years ago

To my knowledge no one has taken a look at the problem yet, so I don't know how much work it'll take. The fact that it builds cleanly is encouraging.

Thanks for asking; let me poke a bit and I'll be back in touch.

trevorriles commented 8 years ago

I just took a look, I looks like the issue is with neotoma. It seems to have been fixed on the master branch.

What is happening is neotoma is generating some erlang code that uses list_to_binary and should instead be using unicode:characters_to_binary.

I have made a request to get a new version released: https://github.com/seancribbs/neotoma/issues/37

macintux commented 8 years ago

Thanks, that does look promising. That particular test fails with 17 as well, unsurprisingly, so I'd wager cuttlefish works under 18.0, although caution is warranted.

trevorriles commented 8 years ago

So my branch name is misleading. I don't currently only have 18 installed so have not had a chance to test other versions.

macintux commented 8 years ago

@tburghart created a branch for 17 previously; I've asked him about the other rebar.config changes.

trevorriles commented 8 years ago

1.7.3 tagged for neotoma I will update the branch.

trevorriles commented 8 years ago

@macintux: Should we tag a new version with this fix?

macintux commented 8 years ago

I’m working on closing out existing PRs before rolling a new version.

-John

On Aug 4, 2015, at 4:18 PM, Trevor Riles notifications@github.com wrote:

@macintux https://github.com/macintux: Should we tag a new version with this fix?

— Reply to this email directly or view it on GitHub https://github.com/basho/cuttlefish/issues/196#issuecomment-127745626.