search

basho / cuttlefish

never lose your childlike sense of wonder baby cuttlefish, promise me?
Apache License 2.0
205 stars 124 forks source link

rebar clean will now remove the generated .erl files from neotoma #198

Closed macintux closed 2 years ago

tburghart commented 8 years ago

What, if any, mechanism is in place to ensure that these are generated files?

My concern is that if, at some point in the future, the files were hand-crafted and checked in by someone who didn't know that they were explicitly flagged for deletion in rebar.config, rebar would merrily delete them. The breakage could be corrected, of course, but how much head scratching might be required to find the problem is indeterminate.

macintux commented 8 years ago

There are no mechanisms at the moment. I was hoping that this was something that rebar could interpret natively, but I don't believe that to be the case. Although, I have not taken a close look at the neotoma plugin for rebar.

Sent from my iPhone

On Jul 31, 2015, at 2:48 PM, Ted Burghart notifications@github.com wrote:

What, if any, mechanism is in place to ensure that these are generated files?

My concern is that if, at some point in the future, the files were hand-crafted and checked in by someone who didn't know that they were explicitly flagged for deletion in rebar.config, rebar would merrily delete them. The breakage could be corrected, of course, but how much head scratching might be required to find the problem is indeterminate.

— Reply to this email directly or view it on GitHub.

macintux commented 8 years ago

basho/rebar#407 addresses this within rebar itself, but no idea if/when that'll become a reality.

macintux commented 8 years ago

One alternative to this approach: include a custom rebar in cuttlefish with the neotoma compiler patch. Seems a bit hacky but so is including rebar at all.