search

basho / cuttlefish

never lose your childlike sense of wonder baby cuttlefish, promise me?
Apache License 2.0
205 stars 124 forks source link

Update lager to 2.2.3 #219

Closed nickelization closed 8 years ago

fadushin commented 8 years ago

+1 c6f9aef

nickelization commented 8 years ago

:+1: c6f9aef

macintux commented 8 years ago

I suspect you both got it wrong. Needs the : : around it, but don't allow auto-complete on the emoji or Bors won't recognize it.

nickelization commented 8 years ago

@macintux Thanks, yeah I actually knew about that wrinkle, and didn't allow it to auto-complete the emoji, so hopefully it should work this time. (I did think that just a bare "+1" without the : characters should've worked though...but I guess I'm not positive about that.)

macintux commented 8 years ago

Actually per our Bors page the +1 should have worked. Dunno.

219 doesn’t show up in the queue status, so maybe Bors is just out to lunch entirely.

-John

On Jul 5, 2016, at 5:53 PM, Nick Marino notifications@github.com wrote:

@macintux https://github.com/macintux Thanks, yeah I actually knew about that wrinkle, and didn't allow it to auto-complete the emoji, so hopefully it should work this time. (I did think that just a bare "+1" without the : characters should've worked though...but I guess I'm not positive about that.)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/basho/cuttlefish/pull/219#issuecomment-230614373, or mute the thread https://github.com/notifications/unsubscribe/ACCsXhyDhYJie93rtvNYO0Ax13noZDW0ks5qStJtgaJpZM4JFcPt.

nickelization commented 8 years ago

I've asked around for help, but nobody seems to know how to fix Bors, so I'm going to give up and merge this manually.