search

basho / cuttlefish

never lose your childlike sense of wonder baby cuttlefish, promise me?
Apache License 2.0
205 stars 124 forks source link

Develop 3.0 mergerebar3 #248

Closed martinsumner closed 4 years ago

martinsumner commented 4 years ago

There was some work to tidy up cuttlefish in Ted's rebar3 branch. This work was required by the bitcask develop-3.0 branch to run its bitcask schema check unit tests.

I've merged in here, but ignoring most of the rebar.config changes (as the rebar3 branch didn't escriptize as expected a cuttlefish file).

There is an update to a cuttlefish_rebar_plugin module - to make it rebar2 not rebar compatible - but this is not yet rebar3 compatible. I can't see anything using this module - so the lack of rebar3 support is hopefully not an issue.

martincox commented 4 years ago

I think cuttlefish is being pulled in (when making a release) from the kyorai fork via the rebar3_cuttlefish plugin, so we may need to bring that inline and merge with this at some point.

martinsumner commented 4 years ago

It is @martincox branch of rebar3_cuttlefish plugin being used at the moment. I have this fork/branch prepared instead (which I've kept up to date with yours).

https://github.com/martinsumner/rebar3_cuttlefish/tree/develop-3.0

Will PR this into the basho version today.

martincox commented 4 years ago

Ahh sound then 👍