search

basho / cuttlefish

never lose your childlike sense of wonder baby cuttlefish, promise me?
Apache License 2.0
205 stars 124 forks source link

Better error printing from the rebar plugin #64

Closed joedevivo closed 10 years ago

joedevivo commented 10 years ago

The problem is that cuttlefish assumes that lager is running for its logging.

That's always true, except when running the rebar plugin. Rebar doesn't have lager built in, and I'm not saying that it should. What this PR does is io:format errors IF errors are returned to the rebar_plugin. Any other path assumes they've been lager'd.

Also piggybacked in here a fix for vm_args that are being output as ~s even when they're integers. This is probably the little devil behind #48. In fact, I know it is because, spoiler alert, I've got a fix for that coming too.

joedevivo commented 10 years ago

For the record, the title of this PR is "better" printing, not "best" printing. You have to agree it's better than the zero printing it did before :)

seancribbs commented 10 years ago

:+1: much improve, wow

joedevivo commented 10 years ago

o man o man o man