search

basho / eleveldb

Erlang LevelDB API
262 stars 177 forks source link

Remove lager parse transform #140

Closed ahf closed 9 years ago

ahf commented 9 years ago

Whilst debugging something where I disabled the cuttlefish dependency, I noticed that lager applied the lager parse transform without actually using lager anywhere. This patch removes the lager_transform from erl_opts.

jonmeredith commented 9 years ago

Is this a code hygiene issue for you, or were you trying to use eleveldb in a project without lager? (seems unlikely given the eleveldb -> cfish -> lager dep chain)

ahf commented 9 years ago

I'm not sure I'd use the term code hygiene here.

It's unclean to have a parse transform applied from something that isn't an explicit dependency IMO, and yes, I'm using eleveldb in an environment where we are not using cuttlefish and thus doesn't fetch the implicit lager dependency (which works just fine as well). There's no calls to lager:* inside of eleveldb itself.

tsloughter commented 9 years ago

Yea, it is just not right, so why keep it?

jonmeredith commented 9 years ago

Agreed.

jonmeredith commented 9 years ago

Applied to 2.0 and 2.1 branches too.