basho / eleveldb

Erlang LevelDB API
262 stars 177 forks source link

fix enconding to new new double/sint64 names #167

Closed gordonguthrie closed 9 years ago

gordonguthrie commented 9 years ago

Goes with these PRs https://github.com/basho/riak_kv/pull/1247 https://github.com/basho/riak_ql/pull/36 https://github.com/basho/riak_test/pull/915

alexmoore commented 9 years ago

Works with the addition of https://github.com/basho/riak_pb/pull/153.

matthewvon commented 9 years ago

+1

alexmoore commented 9 years ago

Thanks for the review @matthewvon, going to stage it for bishop and merge when all the PRs are ready.

alexmoore commented 9 years ago

+1 f218ecbcc6a385834836f55ac21d8ab7d9bf650b

DSomogyi commented 9 years ago

RTS-509

lukebakken commented 9 years ago

Output of make test:

======================== EUnit ========================
module 'eleveldb_ts'
  eleveldb_ts: simple_encode_key_test...ok
  eleveldb_ts: simple_encode_record_test...[0.006 s] ok
  eleveldb_ts: simple_decode_record_test...ok
  [done in 0.015 s]
module 'eleveldb_bump'
  [done in 0.001 s]
module 'basho_bench_driver_eldb'
module 'iterators'
enif_send: env==NULL on non-SMP VMtools.mk:7: recipe for target 'test' failed
make: *** [test] Aborted (core dumped)
lukebakken commented 9 years ago

+1 0bf857ee9f7a1a01bafc83c48391b63b6d1cbb87

lukebakken commented 9 years ago

@borshop retry

lukebakken commented 9 years ago

@borshop merge