basho / eleveldb

Erlang LevelDB API
263 stars 176 forks source link

Test cleanup #239

Closed tburghart closed 7 years ago

tburghart commented 7 years ago

This started with fixing tests to NOT leave test files all over the place, but it quickly became apparent that many of the tests weren't running at all.

Turn off whitespace diffs by appending ?w=1 (or &w=1, as appropriate) to the URL.

With these changes:

Note: This does nothing about the cuttlefish kludge, sorry MvM.

thumbot commented 7 years ago
basho/trb-test-cleanup 31952a9 :arrow_right: develop 996cb43 :white_check_mark: completed
Looks good! :+1:
:white_check_mark: MERGE

> Started at: 2017-01-28 10:41 > Duration: 1 seconds. > Result: OK > Message: Merge Success: basho/trb-test-cleanup 31952a9ed8112eb55afeae16f70837c4e9692bb4 onto target branch: develop 996cb43e52519d91f2f775b428dccddf500a3e94 > Exit Code: OK > :page_facing_up:

``` Updating 996cb43..31952a9 Fast-forward (no commit created; -m option ignored) src/eleveldb.erl | 467 +++++++++++++++++++++++++++++++++++++---------------- test/cacheleak.erl | 76 +++++---- test/cleanup.erl | 223 ++++++++++++------------- test/iterators.erl | 181 ++++++++++----------- 4 files changed, 573 insertions(+), 374 deletions(-) ``` --------------------------------------------------
tburghart commented 7 years ago

Closed and branch deleted because at least some builders, somewhere, still have issues with slashes in branch names.

PR #240 is the relevant replacement.