Test cleanup

[tburghart]

This started with fixing tests to NOT leave test files all over the place, but it quickly became apparent that many of the tests weren't running at all.

Turn off whitespace diffs by appending ?w=1 (or &w=1, as appropriate) to the URL.

With these changes:

• All tests actually run, and pass.
• A few tests have been added that seemed appropriate.
• All tests write only in /tmp and clean up after themselves.
• All relevant cases of failures that would throw a badmatch are now enclosed in appropriate ?assert... macros.
• The fundamental behavior of the tests hasn't been changed.

Note: This does nothing about the cuttlefish kludge, sorry MvM.

This PR replaces #239 with a branch name that should be compatible with all builders.

[thumbot]

trb-test-cleanup db0d66d	:arrow_right:	develop 996cb43	:white_check_mark: completed

Looks good! :+1:

:white_check_mark: MERGE

> Started at: 2017-01-29 05:00 > Duration: 0 seconds. > Result: OK > Message: Merge Success: trb-test-cleanup db0d66dacfa6aa05e54ce9ebf13c50817585fb62 onto target branch: develop 996cb43e52519d91f2f775b428dccddf500a3e94 > Exit Code: OK > :page_facing_up:

``` Updating 996cb43..db0d66d Fast-forward (no commit created; -m option ignored) src/eleveldb.erl | 498 ++++++++++++++++++++++++++++++++++++++--------------- test/cacheleak.erl | 82 +++++---- test/cleanup.erl | 224 ++++++++++++------------ test/iterators.erl | 181 +++++++++---------- 4 files changed, 606 insertions(+), 379 deletions(-) ``` --------------------------------------------------

[matthewvon]

I have executed the buildbot automation against this branch. There were 4 failing platforms out of 16. This is the typical count. I manually reviewed the failing four. Two executed fine upon manual retest. The other two (smartos1.8 and freebsd10) were typical resource problems. Not going to sweat it. I +1 from the automation viewpoint.

[thumbot]

trb-test-cleanup 89a5756	:arrow_right:	develop 254cba3	:white_check_mark: completed

Looks good! :+1:

:white_check_mark: MERGE

> Started at: 2017-02-04 04:42 > Duration: 1 seconds. > Result: OK > Message: Merge Success: trb-test-cleanup 89a57560daba6b13c2b53e774bb5afe637791829 onto target branch: develop 254cba3d1d78f5178f5185e28fc156cc7bba48cc > Exit Code: OK > :page_facing_up:

``` Updating 254cba3..89a5756 Fast-forward (no commit created; -m option ignored) src/eleveldb.erl | 502 ++++++++++++++++++++++++++++++++++++++--------------- test/cacheleak.erl | 82 +++++---- test/cleanup.erl | 224 ++++++++++++------------ test/iterators.erl | 181 +++++++++---------- 4 files changed, 610 insertions(+), 379 deletions(-) ``` --------------------------------------------------

[JeetKunDoug]

+1