search

basho / eleveldb

Erlang LevelDB API
263 stars 176 forks source link

Add -stdlib=libc++ flag when building snappy #258

Open jvf opened 4 years ago

jvf commented 4 years ago

Addendum Fixup to #245, adding the -stdlib=libc++ when building Snappy. This is necessary to build on macOS. Tested on macOS 10.14.6. See also #252 for the initial issue.

jvf commented 4 years ago

@mergefailure I don't see a PR by you. Do you mean #254?

mergefailure commented 4 years ago

that’s right #254

On 11 Dec 2019, at 14:08, Jens Fischer notifications@github.com wrote:

 @mergefailure I don't see a PR by you. Do you mean #254?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

jvf commented 4 years ago

I saw #254 and I it would solve the problem more elegantly and would welcome if it gets merged. Given the low activity in this repo and the amount of changes in #254 my hopes for getting it merged any time soon are low.

My PR is a minimally invasive fixup to an already merged PR (#245). My hope is that this has a slightly higher chance of getting merged.

martinsumner commented 4 years ago

@jvf work to resolve various compatibility/build issues have been rolled into develop-3.0. Does that branch build for you OK on OSX (it does for me)?

The develop branch is not an active branch from a riak perspective, so perhaps there shouldn't be an issue with respect to accepting PRs such as this. If you do need something merged into there, then @martincox would be the best person to raise it with.

There is a bit of a general problem with eleveldb wrt PRs and issues. There's no-one in the riak community who feels comfortable touching code (other than perhaps for very basic build changes like this). If there's someone out there who is more comfortable with pro-actively maintaining it, it might be an idea to request transfer of ownership out of the basho repo - as happened with lager and webmachine.