basho / eleveldb

Erlang LevelDB API
263 stars 176 forks source link

Depend on system snappy #271

Closed hmmr closed 1 year ago

hmmr commented 1 year ago

Rather than downloading and building snappy, depend on libsnappy preinstalled on the host system.

Also, use --depth=1 when cloning leveldb.

codeadict commented 1 year ago

I'm getting ld: library not found for -lsnappy on an ARM mac by installing snappy from homebrew. I'll do more investigation this weekend but seems like the problem doesn't get fixed for OSX

ioolkos commented 1 year ago

@codeadict I think we had a couple of commits over at the VerneMQ fork, related to building on FreeBSD and Darwin. Not sure this is directly related, but maybe there's some stuff useful to upstream or cherrypick. https://github.com/vernemq/eleveldb/pull/10

hmmr commented 1 year ago

For the record, on FreeBSD-13.1, after pkg install snappy, it is required to export LDFLAGS=-L/usr/local/lib before running make.

hmmr commented 1 year ago

Closing, in favor of #272.

hmmr commented 1 year ago

Closing, in favor of #272.