search

basho / erlang_js

A linked-in driver for Erlang to Mozilla's Spidermonkey Javascript runtime.
Apache License 2.0
238 stars 88 forks source link

Add app_env var for script timeout #33

Closed russelldb closed 10 years ago

russelldb commented 11 years ago

js_driver:eval_js/2 uses a macro SCRIPT_TIMEOUT for the amount of time to wait for a js script to execute before timing out. In some instances (testing JS map reduce on limited hardware) it would be handy to set this timeout higher.

Use the 'erlang_js' app_env var 'script_timeout' and any int value. Timeout is in milliseconds.

joedevivo commented 11 years ago

+1 this worked great in riak 1.2.1 with riak_test, but I did have to rebase before rebar would allow the dependency to work.

strange commented 11 years ago

Our use application:get_env/2? A little messier, but nice to get rid of the dep.

cmeiklejohn commented 10 years ago

app_helper is only going to work when bundled with riak/riak_core. Should this be modified to use application:get_env as recommended above?

cmeiklejohn commented 10 years ago

Closing in favor of #41.